-
Notifications
You must be signed in to change notification settings - Fork 235
Remove Python 3.8 to fix build issues #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes support for Python 3.8 to fix build issues by updating version requirements across configuration files and documentation.
- Updated classifiers and the Python requirement in pyproject.toml
- Updated Docker README and environment.yml to reflect Python 3.9
- Updated workflow configurations in .github/workflows/build.yml to remove Python 3.8 support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
pyproject.toml | Removed Python 3.8 classifier and updated requires-python to >=3.9 |
etc/docker/demo-base/README.md | Updated description to indicate usage of Python 3.9 |
docs/environment.yml | Changed the Python dependency version from 3.8 to 3.9 |
.github/workflows/build.yml | Removed Python 3.8 from the test matrix and updated configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lresende. This has my approval whenever you are done.
Thank you @kevin-bates , I believe there are two main issues here:
Will find some time and continue on this until we get a green build |
67e736f
to
9943114
Compare
0dc0b1a
to
8b0e0a0
Compare
Update ssh keygen Uses python 3.10
No description provided.